*: harden partial signature exchange#4599
Open
pinebit wants to merge 1 commit into
Open
Conversation
Bind partial signatures received during the DKG lock-hash exchange to their authenticated sender: a peer may only contribute partial signatures under its own assigned share index. parsigex.handle now passes the authenticated sender to the verify function; the core workflow verifier ignores it, since those partial signatures are already verified cryptographically against the pubshare for the claimed share index. The DKG exchanger keys the binding on each peer's assigned share index via a peer map, so it stays correct when share indices are not contiguous with peer positions, such as after operators are removed. newExchanger validates its peer index and peer map up front and returns an error on a misconfigured map instead of silently timing out. category: bug ticket: none feature_flag: none Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
pinebit
changed the title
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #4599 +/- ##
=======================================
Coverage 57.58% 57.58%
=======================================
Files 246 246
Lines 33675 33704 +29
=======================================
+ Hits 19392 19410 +18
- Misses 11845 11849 +4
- Partials 2438 2445 +7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bind partial signatures received during the DKG lock-hash exchange to their authenticated sender: a peer may only contribute partial signatures under its own assigned share index.
parsigex.handlepasses the authenticated sender to the verify function. The core workflow verifier (NewEth2Verifier) ignores it, since those partial signatures are already verified cryptographically against the pubshare for the claimed share index, socharon runbehaviour is unchanged.newExchangervalidates its peer index and peer map up front and returns an error on a misconfigured map instead of silently timing out.category: bug
ticket: none